CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

/retest

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

/lgtm deps

/lgtm deps

The same question as before, though, before we merge, is there a logic to keeping the pinned dependencies from bit-rotting, @phlax?

The same question as before,...

Similar answer to before - there is examples/DEVELOPER.md which is my intention to update - but i have a few more changes i would like to make first

this one is a pretty straight refactoring - it shouldnt change how things work - but as you rightly point out it changes the standards for including deps amongst other things - im defo happy to follow up if that is ok

That's great, please create an issue pointing to these two (and other relevant) PR's to note the WIP/TODO?

Hi! Came here from #20915 which is supposedly fixed with this here thread. But I still get ERROR [front-proxy_service2 internal] load metadata for docker.io/library/flask_service:python-3.10-slim-bullseye
That image doesn't exits in the repo nor locally.

hi @Moonsilence can you post the hash of your local repo when the error occurs

Hi @phlax !

I cloned the repo this morning.

git rev-parse HEAD
cedb988

can you post the exact commands you are running when this happens

also, maybe docker/docker-compose versions

@phlax Sure, appreciated!

I am trying to run the Sandbox "Front Proxy" from the latest official Envoy documentation:
https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/front_proxy#step-1-start-all-of-our-containers

The very first command is:
docker-compose build --pull

My version of docker-compose: v2.6.1
Using Docker Desktop on Windows, running Docker in the WSL2 Ubuntu Distro.

Error Messages:

 => CANCELED [front-proxy_front-envoy internal] load metadata for docker.io/envoyproxy/envoy-dev:latest                                                               2.0s
 => CANCELED [flask_service:python-3.10-slim-bullseye internal] load metadata for docker.io/library/python:3.10.5-slim-bullseye@sha256:2ae2b820fbcf4e1c5354ec39d0c7e  2.0s
 => ERROR [front-proxy_service1 internal] load metadata for docker.io/library/flask_service:python-3.10-slim-bullseye                                                 2.0s

 > [front-proxy_service1 internal] load metadata for docker.io/library/flask_service:python-3.10-slim-bullseye:

failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

ok - i see

some of the docs have the instruction of docker-compose up --build -d this is what i tested when fixing

and i think should work with little difference in outcome

ill update the docs to reflect the better command

can you confirm this command works ok @Moonsilence ?

hmm, actually im realising that doesnt pull the images if they exist already and that this was added for a reason (albeit an imperfect one)

ill test again further - i was convinced i fixed this at least for sme of the examples, but now im wondering...

ok - so it seems my fix didnt work 8( - altho it was needed for other reasons (and i think partially resolved the issue)

what does seem to work is doing the following...

$ docker-compose pull
$ docker-compose up --build -d

ill update the docs with these instructions

@phlax Thanks, I have the "Front Proxy" example up and running, using your commands from previous post.

docker-compose pull

... gives me a warning:

 ⠿ flask_service Error                                                                                                                                                2.5s
WARNING: Some service image(s) must be built from source by running:
    docker compose build flask_service
Error response from daemon: pull access denied for flask_service, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

...but then...

docker compose build flask_service

... finally builds that image. Then your next command

docker-compose up --build -d

spins up the deployment.

Thanks!!

hmm - thats odd this is the outpuf of pull for me

..front-proxy$ docker-compose pull
Pulling flask_service ... done
Pulling front-envoy   ... done
Pulling service1      ... done
Pulling service2      ... done
WARNING: Some service image(s) must be built from source by running:
    docker-compose build flask_service
..front-proxy$ echo "$?"
0

$ docker --version
Docker version 20.10.10, build b485636

$ docker-compose --version
docker-compose version 1.29.2, build unknown

ill update the docs on the basis that it works mostly (i have tested in other similar env - debian <> ubuntu)

not sure why you are getting an error still - but v2.6.1 doesnt seem to exist for docker-compose

...for docker-compose

i see that is the version for docker compose (no hyphen)

this is currently untested im afraid

pr with updated docs instructions is here #22132